Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 3rd party image deps update workflow #4223

Merged
merged 9 commits into from
Dec 14, 2023

Conversation

sgalsaleh
Copy link
Member

@sgalsaleh sgalsaleh commented Dec 14, 2023

What this PR does / why we need it:

Package version needs to be set in the apko file before the image gets built to pick up the new version.

Which issue(s) this PR fixes:

Fixes SC-94750

Special notes for your reviewer:

Steps to reproduce

Does this PR introduce a user-facing change?

NONE

Does this PR require documentation?

NONE

cbodonnell
cbodonnell previously approved these changes Dec 14, 2023
cbodonnell
cbodonnell previously approved these changes Dec 14, 2023
@sgalsaleh sgalsaleh merged commit f81c022 into main Dec 14, 2023
161 of 164 checks passed
@sgalsaleh sgalsaleh deleted the fix-3rd-party-image-deps-workflow branch December 14, 2023 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants